All Questions
7 questions
-1votes
1answer
715views
Refactoring bad code switch statment without distort everything
Once in a while I’m stumbling on switch statements during a Code Review session. I would like to find a more elegant way of this code .... $istannceOfClass = $repository->loadFoo(); switch($...
1vote
3answers
175views
Should I keep "redirect only" methods in my Controller?
Controller: function indexAction() { if ($condition) $this->renumPosition($id); //LINE #1 } //Redirect only - function's sole purpose is to call another function function ...
- 8,257
3votes
3answers
333views
Which pattern can I use for doing computations involving similar yet different object subtypes?
How do I design code that has two qualities: uses similar but different subtypes of an object uses similar but different types of computation on the above objects Example I am refactoring this from ...
- 8,257
0votes
1answer
98views
Are there any strong reasons to use DI for sub-classes that are known to be tightly coupled to their parent containers?
I have Product classes for Products A through Z. And each Product class has its own set of product-specific subclasses, which I'd say are tightly coupled to them, like so: //specific product class ...
- 8,257
4votes
1answer
251views
How to use OO Design to Refactor a Library with Functions that are specific Product-aware
I have a class that acts as a library of functions for various products. To compute its data, the function currently needs to be aware of all product names. Depending on which product calls the ...
- 8,257
0votes
2answers
822views
Breaking up a large PHP object used to abstract the database. Best practices?
Two years ago it was thought a single object with functions such as $database->get_user_from_id($ID) would be a good idea. The functions return objects (not arrays), and the front-end code never ...
11votes
5answers
2kviews
Why is my class worse than the hierarchy of classes in the book (beginner OOP)?
I am reading PHP Objects, Patterns, and Practice. The author is trying to model a lesson in a college. The goal is to output the lesson type (lecture or seminar), and the charges for the lesson ...
- 615
